← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~stevenk/launchpad/bugs-information_type-ui-secrecy into lp:launchpad

 

The proposal to merge lp:~stevenk/launchpad/bugs-information_type-ui-secrecy into lp:launchpad has been updated.

Description changed to:

Add a new feature flag, disclosure.show_information_type_in_ui.enabled, and make use of it inside Bug:+secrecy. I've been quite careful with the changes I've made and I have left the existing tests alone, and added new ones that enable the feature flag and make sure we can change the information_type and that the vocab is used correctly.

I've also cleaned up a little bit of lint, and made sure that InformationTypeVocabulary works with the widget we're using.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/bugs-information_type-ui-secrecy/+merge/102624
-- 
https://code.launchpad.net/~stevenk/launchpad/bugs-information_type-ui-secrecy/+merge/102624
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/bugs-information_type-ui-secrecy into lp:launchpad.


References