← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~stevenk/launchpad/bugs-information_type-ui-filebug into lp:launchpad

 

The proposal to merge lp:~stevenk/launchpad/bugs-information_type-ui-filebug into lp:launchpad has been updated.

Description changed to:

Building on the changes introduced in https://code.launchpad.net/~stevenk/launchpad/bugs-information_type-ui-secrecy/+merge/102624, and the march forward to showing information_type in the UI, show it on Bug:+filebug. As before, I've left the existing tests alone and added new ones which set the feature flag.

This branch sort of closes bug 136937, but I'd rather not do that until the feature flag is on on production.

I have not moved the JavaScript in the filebug-macros template out to a .js file since I'd rather not make any far reaching changes in these branches to increase the chances we can beta the UI on qastaging next week.

I have cleaned up what I felt was some terrible imports, and have switched security_related to using copy_field, rather than the Bool() magic it was using before.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/bugs-information_type-ui-filebug/+merge/102635
-- 
https://code.launchpad.net/~stevenk/launchpad/bugs-information_type-ui-filebug/+merge/102635
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/bugs-information_type-ui-filebug into lp:launchpad.


References