launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/bug-962801-1 into lp:maas has been updated.

Description changed to:

This is the first of several branches needed to reorganize the fake-cobbler test.  (It's a bit of a misnomer: it's mostly a cobblerclient test).

In order to be able to split up the test without losing its helpers, I first need to make the helpers reusable.  That's what I do here, or at least: I do part of that job here.  Two helpers for creating fake cobbler sessions do essentially the same thing, though this is a bit difficult to spot.  Gavin, my arbitrarily chosen victim, confirms that this appears sane.

In my following branches I'll move more of the helpers into provisioningserver.testing.fake_cobbler (perhaps cleaning them up a bit or generalizing them more along the way) and then start moving test cases.

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-962801-1/+merge/102683
-- 
https://code.launchpad.net/~jtv/maas/bug-962801-1/+merge/102683
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-962801-1 into lp:maas.