launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/move-models-modules into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/move-models-modules/+merge/103041

This turns our nontrivial models modules into packages.  As per the plan, it makes no other changes whatsoever.  This still works well with South and, thanks to bzr's handling of moving files, should cause no conflicts for pending branches.

After this, new model classes will go into separate modules in the new src/*/models/ directories.  They still need to be imported into, and exported from, the new src/*/models/__init__.py.  Be sure to keep enums separate from models, and to declare foreign-key targets by model class name rather than by model class.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/move-models-modules/+merge/103041
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/move-models-modules into lp:maas.

=== added directory 'src/maasserver/models'
=== renamed file 'src/maasserver/models.py' => 'src/maasserver/models/__init__.py'
=== added directory 'src/metadataserver/models'
=== renamed file 'src/metadataserver/models.py' => 'src/metadataserver/models/__init__.py'