launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Approve code

Hi Stuart.

I like your solution. I looked at the bug too and pondered if a try/except would be easier to maintain than a queue. Can you add a comment before the break to explain catching the IndexError is safer than looking at the length because the work is threaded?
-- 
https://code.launchpad.net/~stub/launchpad/garbo/+merge/103430
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.