launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Hi Rick.

I think I already answered your first question.

I reviewed the changes I made...Lp is already providing a title for all the links. The title attribute was introduced in HTML 3.0 and enforced in HTML 3.2 in 1997. All screen readers support title because it is a valid attribute for all HTML elements. The alt attribute is historical and only used by img, applet, area, and input. We do not want to add an invalid attribute.

Yes we have two modules that import widget-position-ext, autocomplete and official_bug_tags. The calls are commented out in autocomplete, and official_bug_tag now uses WidgetPosition.CC. Maybe the code was updated to use the standard lib when .CC was moved into it. We do not need widget-position-ext. I removed the remaining calls to it. I added a test (because I already took the painful step of adding a test module) to demonstrate that the bug tag error message is shown.

As for the container element in a collapsible, it is needed so that lp.app.expander can find the second chunk and add the lazr-closed class.
-- 
https://code.launchpad.net/~sinzui/launchpad/progressive-enhancement-ftw/+merge/103733
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.