launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12-04-27 03:43 PM, Richard Harding wrote:
> My only suggestion is around the email wording. In the effort of
> keeping things simple I'd leave out the bits about reasoning.

In general, when you leave out the bits about reasoning, users
complain and file bugs and the response is disorganized, because the
bug triager is not the person who made the change.  I think we can
give users a better experience and more coherent responses by giving
reasoning and directing them to the relevant bug.

> I'd also move the usage of the webui up so that it's more prominent
> in the text.

I think lp-propose-merge should be more prominent because it's a
better fit, and because it's more likely to be informative.

Merge directives are generated and sent using the "bzr send" command.
 I wrote both "send" and "lp-propose-merge", and I view
"lp-propose-merge" as its clear successor to "bzr send" for use with
Launchpad.  Both command-line tools, and they function similarly, with
"send" launching your email client for you to type the description,
while "lp-propose-merge" launches your editor for you to type the
description.

It seems like the number of people who know about merge proposals but
don't know they can create them via the web UI is very small.  So I
think the existence of the lp-propose-merge command is more likely to
be new information.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk+a/HUACgkQ0F+nu1YWqI2JUwCfSHyiaDSPGBs2eEO9Eow7swyz
llwAnRF2DDIQ8dQbW8tGrdezmDs7zIgj
=3UFR
-----END PGP SIGNATURE-----

-- 
https://code.launchpad.net/~abentley/launchpad/remove-create-merge-proposal-job/+merge/103929
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.