launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/privacy-portlet-colour-change into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/privacy-portlet-colour-change/+merge/104188

The privacy JS will currently change the background of any privacy portlet it finds to dark red when the hide_privacy_notification() method is called. This is causing issues with information type changing, and the code should no longer be used. In fact, it also looks to have been untested.
-- 
https://code.launchpad.net/~stevenk/launchpad/privacy-portlet-colour-change/+merge/104188
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/privacy-portlet-colour-change into lp:launchpad.

=== modified file 'lib/lp/app/javascript/privacy.js'
--- lib/lp/app/javascript/privacy.js	2011-09-26 06:30:07 +0000
+++ lib/lp/app/javascript/privacy.js	2012-04-30 23:39:20 +0000
@@ -127,19 +127,6 @@
         fade_out.run();
         body_space.run();
         login_space.run();
-
-        var privacy_portlet =  Y.one('.portlet.private');
-        if (privacy_portlet !== null) {
-            var portlet_colour = new Y.Anim({
-                node: privacy_portlet,
-                to: {
-                    color: '#fff',
-                    backgroundColor:'#8d1f1f'
-                },
-                duration: 0.4
-            });
-            portlet_colour.run();
-        }
     }
 }
 namespace.hide_privacy_notification = hide_privacy_notification;