launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/prep-config-tests-migration into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/prep-config-tests-migration/+merge/104204

As per the migration plan. This prepares the Config and ConfigManager tests for migration on Friday 2012-04-11.  I'm speeding things up slightly to 2 migrations per week, seeing that the CommonInfo migration went smoothly.

The one really troublesome migration, of course, will be Node.  I'm leaving that one for last so that with a bit of luck we can do it by renaming src/maasserver/models/__init__.py to src/maasserver/models/node.py (and putting a tiny new __init__.py in its old place).  That'll minimize conflicts on Node model code: bzr will treat the move as a file rename.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/prep-config-tests-migration/+merge/104204
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/prep-config-tests-migration into lp:maas.

=== modified file 'src/maasserver/tests/test_models.py'
--- src/maasserver/tests/test_models.py	2012-04-30 16:24:33 +0000
+++ src/maasserver/tests/test_models.py	2012-05-01 05:28:21 +0000
@@ -1347,6 +1347,7 @@
         pass
 
 
+# Due for model migration on 2012-04-11
 class ConfigDefaultTest(TestCase, TestWithFixtures):
     """Test config default values."""
 
@@ -1355,6 +1356,7 @@
         self.assertEqual(gethostname(), default_config['maas_name'])
 
 
+# Due for model migration on 2012-04-11
 class Listener:
     """A utility class which tracks the calls to its 'call' method and
     stores the arguments given to 'call' in 'self.calls'.
@@ -1367,6 +1369,7 @@
         self.calls.append([args, kwargs])
 
 
+# Due for model migration on 2012-04-11
 class ConfigTest(TestCase):
     """Testing of the :class:`Config` model and its related manager class."""