launchpad-reviewers team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

408	+ return filter(None, [
409	+     get_module(src_path, package, 'enum')
410	+     for package in os.listdir(src_path)])

I know filter() is more concise here because you don't want to call get_module() twice, but I have vague recollections of it being deprecated.

How about:
modules = [get_module(src_path, package, 'enum') for package in os.listdir(src_path)]
return [module for module in modules if module]

Or perhaps Python Panella will suggest something better...!
-- 
https://code.launchpad.net/~jtv/maas/jsenums/+merge/104126
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/jsenums into lp:maas.