launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

The proposal to merge lp:~jml/launchpad/narrow-commercial-celebrity into lp:launchpad has been updated.

Description changed to:

We don't need getCommercialPPAs at all. It was added for us, we are the only users, and we don't use it. Therefore, it should be deleted. Thus let it be written, thus let it be done.

This branch deletes them both.  It also deletes a doctest, archive-commercial.txt, which doesn't really do much once getCommercialPPAs is deleted.  The sole remaining test went into test_archive_privacy, which I also went to work on with a pair of pliers and a blowtorch, moving stuff out of setUp, using simpler layers and hopefully making tests more clear.

I've updated the documentation in IArchive for commercial to match our current understanding.

If it lands as-is, this branch will leave me 113 deletions in credit (by diffstat's measure).  I'm going to need them.

For more details, see:
https://code.launchpad.net/~jml/launchpad/narrow-commercial-celebrity/+merge/104236
-- 
https://code.launchpad.net/~jml/launchpad/narrow-commercial-celebrity/+merge/104236
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.