launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #07496
Re: [Merge] lp:~jml/launchpad/drop-special-commercial-permissions into lp:launchpad
Review: Approve
Hi,
This looks good to me from a code point of view.
Agree about the need for integration testing.
I think that we may also want to audit the current PPAs to make sure that
s-c-a won't lose permissions that it needs to complete sales of something
available in software-center. I'm not exactly sure how we would determine
that though.
Thanks,
James
--
https://code.launchpad.net/~jml/launchpad/drop-special-commercial-permissions/+merge/104270
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References