launchpad-reviewers team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Cool, thank you.  This will be a big help.

A brief summary of our IRC conversation follows.  All of these are negotiable.

 - I don't think we should raise an exception if LP no longer has a test in the test list.  The previous code did not have that behavior.

- ordered_layers isn't doing anything, and we should delete it.

- The suites_by_layer data structure is unnecessarily inefficient for the question you want to answer.  If instead you build a map of test name to (layer, test), you can replace find_layers with a single hash lookup.

- We should include a comment as to why the code is maintaining order, so that future code navigators will have a clue as to intent.
-- 
https://code.launchpad.net/~bac/launchpad/ordered-load-list/+merge/104287
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.