launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/bug-991553 into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #991553 in MAAS: "maas-import-isos ignores http_proxy"
  https://bugs.launchpad.net/maas/+bug/991553

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-991553/+merge/104328

As requested by Julian after contribution from Scott.  This updates our documentation for the benefit of people who want to run maas-import-isos from behind an http proxy.  Running the script in “sudo” gives it an environment without variables such as http_proxy that you might have set in your shell.

Other ways of doing this would include “sudo su” or “sudo -i” (both of which would create a root login environment, including any http_proxy setting from /etc/profile).  But what if you run the script on a server that's not normally supposed to talk http to the outside world?  The http_proxy setting might be local to your current shell, or might not normally be set for root.  Either way, I think this spelling makes the issue explicit.  Even if you simply forgot to set http_proxy, this will remind you to set it.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/bug-991553/+merge/104328
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-991553 into lp:maas.

=== modified file 'HACKING.txt'
--- HACKING.txt	2012-04-27 12:53:57 +0000
+++ HACKING.txt	2012-05-02 05:53:18 +0000
@@ -157,7 +157,7 @@
 Now run ``maas-import-isos`` to download Ubuntu precise and create the
 necessary MAAS profiles::
 
-    $ sudo ./scripts/maas-import-isos
+    $ sudo http_proxy=$http_proxy ./scripts/maas-import-isos
 
 Add yourself as a user in Cobbler. For convenience, give yourself the
 password ``test``::

=== modified file 'INSTALL.txt'
--- INSTALL.txt	2012-04-11 12:50:17 +0000
+++ INSTALL.txt	2012-05-02 05:53:18 +0000
@@ -87,11 +87,17 @@
 Import the Ubuntu images
 ========================
 
-MAAS will check for and download new Ubuntu images once a
-week. However, you'll need to download them manually the first time::
+MAAS will check for and download new Ubuntu images once a week.
+However, you'll need to download them manually the first time::
 
   $ sudo maas-import-isos
 
+If you are using an HTTP proxy, bear in mind that the "sudo" will not
+pass your http_proxy environment variable on to the script.  If that is
+a problem, pass it on explicitly::
+
+  $ sudo http_proxy=$http_proxy maas-import-isos
+
 
 Next steps
 ==========