launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/bug-992372 into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #992372 in MAAS: "Disabled node actions look just like enabled ones"
  https://bugs.launchpad.net/maas/+bug/992372

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-992372/+merge/104347

As detailed to a defenseless Julian, which I retroactively claim as a pre-imp: our CSS sets styles for buttons, which can in HTML/CSS terms be various different things (buttons, other things but with the “button” class, ...) including input elements of type “submit.”  It also sets styles for disabled buttons.  Here comes the same list again, though all with the suffix “.disabled” to indicate that they must have the “disabled” class in order to match that CSS stanza.

However the CSS stanza for disabled buttons omits the input-elements-of-type-“submit” alternative.  And so, disabled buttons get styled like regular buttons.

Here I fix that by adding input-elements-of-type-“submit” to the list of things that can look disabled.  It looks just like a disabled Delete Node button used to look in 1.0.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/bug-992372/+merge/104347
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-992372 into lp:maas.

=== modified file 'src/maasserver/static/css/forms.css'
--- src/maasserver/static/css/forms.css	2012-04-04 14:31:51 +0000
+++ src/maasserver/static/css/forms.css	2012-05-02 08:59:20 +0000
@@ -130,7 +130,8 @@
 /* Disabled buttons */
 .yui3-button.disabled,
 .button.disabled,
-button.disabled {
+button.disabled,
+input[type="submit"].disabled {
     cursor: not-allowed;
     border-color: #999;
     background-image: linear-gradient(bottom, rgb(200,200,200) 0%, rgb(150,150,150) 100%);