launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

>
> test_findIndirectGranteePermissionsByPolicy() is testing 4 cases. I think the test should be 4 tests with a common setup. A failure in the first part of the test does not mean the slicing or artefact grant aspects are also broken.

I've split the test. The test was based on the tests for direct 
grantees so I've split those tests as well so everything is consistent.

-- 
https://code.launchpad.net/~wallyworld/launchpad/revoke-access-delete-subscriptions-job-2/+merge/104522
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.