← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jml/launchpad/commercial-means-shut-up into lp:launchpad

 

Hi,

This change looks ok to me.

Mentioning the fact that it is only valid for private PPAs in the docstrings
might be useful in helping people understand the point, or avoiding them
learning the hard way by hitting the validatePPA check.

Thanks,

James

-- 
https://code.launchpad.net/~jml/launchpad/commercial-means-shut-up/+merge/104739
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References