launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Review: Approve code

Hi Jono,

* In lib/lp/soyuz/tests/test_archive.py you deleted setCommercial but still call it.  You'll want to fix that.

* On IRC we discussed backwards compatibility and you explained nothing in 1.0 or previous has changed.  Thanks.

Thanks for the attentiveness and general cleanup you made.
-- 
https://code.launchpad.net/~jml/launchpad/commercial-means-shut-up/+merge/104739
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.