launchpad-reviewers team mailing list archive

[Steve Langasek <steve.langasek@xxxxxxxxxxxxx>]

Steve Langasek has proposed merging lp:~vorlon/launchpad/lp.994110 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #994110 in Launchpad itself: "summit should not key on bp definition state"
  https://bugs.launchpad.net/launchpad/+bug/994110

For more details, see:
https://code.launchpad.net/~vorlon/launchpad/lp.994110/+merge/105078

Don't filter the blueprint list in the sprint export view based on the
spec's definition status.  In Ubuntu, blueprints are sometimes (often)
carried over from one cycle to another and we want to rediscuss them at
subsequent UDSes.  Since the feed is used as input to the session scheduler,
this extra check requires us to remember to toggle two separate things on
the blueprint to get it re-discussed.  We should only need to target the
blueprint to the sprint to get it into the scheduler.
-- 
https://code.launchpad.net/~vorlon/launchpad/lp.994110/+merge/105078
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~vorlon/launchpad/lp.994110 into lp:launchpad.

=== modified file 'lib/lp/blueprints/browser/sprint.py'
--- lib/lp/blueprints/browser/sprint.py	2012-01-01 02:58:52 +0000
+++ lib/lp/blueprints/browser/sprint.py	2012-05-08 15:01:20 +0000
@@ -470,11 +470,6 @@
             if spec.priority < SpecificationPriority.UNDEFINED:
                 continue
 
-            if (spec.definition_status not in
-                [SpecificationDefinitionStatus.NEW,
-                 SpecificationDefinitionStatus.DISCUSSION,
-                 SpecificationDefinitionStatus.DRAFT]):
-                continue
             model_specs.append(spec)
 
         people = defaultdict(dict)