launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

> 
> I do not think the change to retractTeamMembership() in person.py is correct.
> I think the change should be in teammmebership.py, possibly in setStatus() or
> in a private function as we handle team participation. Consider the case where
> the team admin is reviewing membership:
>     https://qastaging.launchpad.net/~registry/+members
> We want to remove canonical-bazaar from ~ registry because the teams members
> are now Lp members. The edit page is acting directly on the TeamMembership
> object. I think it is just changing status. Users can change status over the
> API. I think we need to review this case to be certain retractTeamMembership()
> is the centeral place for this change.

Thanks for pointing out this flaw in the implementation. I have moved the code to the setStatus() method.
-- 
https://code.launchpad.net/~wallyworld/launchpad/revoke-membership-delete-subscriptions-996882/+merge/105264
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.