launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Needs Information code

Thank you for this  branch. I would like you to review the signatures of getMostRecentlyReportedBugs() and getMostRecentlyFixedBugs(). I was surprised to see a template call the new getMostRecentlyReportedBugs since it cannot pass the limit, and I was surprised to a see a method since templates should all properties. I investigated and see you are consistent with the inconsistency that bug templates like to call methods with kwargs.

But I looked at all the callsites of getMostRecentlyReportedBugs() and getMostRecentlyFixedBugs(). None use the limit kwarg. I do not think the kwarg justifies itself. We have no plans to make those disapointing portlets show more than 5 items.
-- 
https://code.launchpad.net/~wgrant/launchpad/bugtaskflat-by-default-3/+merge/105445
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.