launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

50	-webkit-box-shadow: 0px 0px 20px 10px #aaa;
51	+ -ms-filter: "progid:DXImageTransform.Microsoft.Shadow(Strength=15, Direction=135, Color='#aaaaaa'), progid:DXImageTransform.Microsoft.Shadow(Strength=15, Direction=315, Color='#aaaaaa')";
52	box-shadow: 0px 0px 20px 10px #aaa;

Yay, I never quite got around to working out the syntax for that.

184	- Y.lp.bugs.bugtask_index.setup_bugtask_index();
185	- Y.on('load', function(e) {
186	+ Y.on('domready', function(e) {
187	Y.lp.code.branchmergeproposal.diff.connect_diff_links();
188	}, window);
189	Y.on('domready', function() {

Could those two domready handlers be merged?

249	+ if (LP.links['me'] !== undefined) {
250	+ Y.one('#edit-tags-trigger').on('click', function(e) {
251	+ e.halt();
252	+ });
253	+ }

Is this still necessary? You removed an XXX comment which suggests it might not be.
-- 
https://code.launchpad.net/~sinzui/launchpad/halt-when-done/+merge/105542
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.