launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/pre-963090 into lp:maas has been updated.

Description changed to:

This addresses some small things I ran into while trying to fix timing-dependent assertions in our JS tests.  I did them in a separate branch because my main branch ran into some mysterious problems and I wanted as few unknowns in that mix as possible.

Things addressed:
 * An animation in the view was started before its "end" handler was set up.
 * Some dashboard views created in the tests were not destroyed; not sure if it was causing trouble.

The cleanups were done by factoring out a factory method.  Also eliminated some repetitive setup.

As a free bonus, I punctuated sentences, and double-quoted free-form text (where an apostrophe should always feel welcome).

Jeroen

For more details, see:
https://code.launchpad.net/~jtv/maas/pre-963090/+merge/105622
-- 
https://code.launchpad.net/~jtv/maas/pre-963090/+merge/105622
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/pre-963090 into lp:maas.