launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~jcsackett/launchpad/banner-fixes into lp:launchpad

To: mp+105729@xxxxxxxxxxxxxxxxxx
From: Richard Harding <rick.harding@xxxxxxxxxxxxx>
Date: Tue, 15 May 2012 01:57:18 -0000
In-reply-to: <20120514221418.27140.27001.launchpad@ackee.canonical.com>
Reply-to: mp+105729@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

This looks good. It'd be nice if you get a sec to add some YUI docs to the code. One day I hope to get it running through http://yui.github.com/yuidoc/ to help people find/use the JS we've got building up. You can see the indicator module for some examples on documenting the methods/ATTRS.

Thanks for sticking through this!
-- 
https://code.launchpad.net/~jcsackett/launchpad/banner-fixes/+merge/105729
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~jcsackett/launchpad/banner-fixes into lp:launchpad
From: j.c.sackett, 2012-05-14