launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Needs Information

Abently, thanks for the update. 

- should the needs_init be moved to the top of the file? I can't find anything that enforces it, but I find usual practice is to have vars setting like that at the top.

- Just a curiosity question, what's the u in the new get(ujob_id)? I tend to auto think unicode with the u prefix, but see here it's a tuple of information.

- What's the long term plan for the run_missing_read and other jobs? It seems that as people add new jobs they'll need to make sure to drop in here and extend this to check for their own items? Are we only worried that certain jobs will drop into this state of ready but no longer scheduled? If it's something that's a rare test case is there some place to document this for future jobs that come along?
-- 
https://code.launchpad.net/~abentley/launchpad/sync-pending-jobs/+merge/105715
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.