launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve code

Thanks for the big cleanup. Couple of repeats

- Please link to the build banner.js in the tests. #177

- Please move the maincontent node generation to setup vs teardown

- Do we still need the animation wait time in #353, or a 400ms wait? 

- 
-- 
https://code.launchpad.net/~jcsackett/launchpad/use-banner-to-cleanup-beta-notifications/+merge/105732
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.