← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/sharing-details-timeout-997343 into lp:launchpad

 

> Thanks Ian.
> 
> - Should the test_withIds add a third branch that doesn't get
> selected/returned in order to test this properly?
> 
> -


Hi Rick, Thanks for reviewing.
The test does indeed add a third branch already. It just doesn't assign it to an unused variable.
-- 
https://code.launchpad.net/~wallyworld/launchpad/sharing-details-timeout-997343/+merge/105774
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References