launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>
Date: Wed, 16 May 2012 13:39:20 -0000
In-reply-to: <20120516012819.26266.59987.launchpad@ackee.canonical.com>
Reply-to: mp+105915@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code*

This branch looks great Colin, thank you!
I am a little confused about how to actually demo your changes, and I think that's mostly my fault due to my my lack of experience with the API.
However, the tests pass, and I liked a lot how you reduced LoC by removing a doctests file and refactoring `test_buildpackagejob`.
Approved, and waiting for Raphaël suggestions.

-- 
https://code.launchpad.net/~cjwatson/launchpad/packageset-score/+merge/105915
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/packageset-score into lp:launchpad
From: Colin Watson, 2012-05-16