launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Richard Harding has proposed merging lp:~rharding/launchpad/meta_1000282 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1000282 in Launchpad itself: "Uncaught TypeError on translations series +imports"
  https://bugs.launchpad.net/launchpad/+bug/1000282

For more details, see:
https://code.launchpad.net/~rharding/launchpad/meta_1000282/+merge/106013

= Summary =
The comment in the import queue js file caused it to not get loaded into the
list of modules in build/js/lp/meta.js. This means the combo loader didn't
know it existed and couldn't load it.

== Pre Implementation ==
N/A

== Implementation Notes ==
Adjust the comment out of the JS block so that the parser that generates the
meta.js can correctly parse the file.

Note that while working this out I hit an error with the addClass() for a non-existent submit button. I wrapped that so that it only applies the class if the button is found.

== Q/A ==
https://translations.launchpad.net/+imports/+index
should load without any JS errors.
-- 
https://code.launchpad.net/~rharding/launchpad/meta_1000282/+merge/106013
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/meta_1000282 into lp:launchpad.

=== modified file 'lib/lp/translations/javascript/importqueue.js'
--- lib/lp/translations/javascript/importqueue.js	2012-04-28 02:51:07 +0000
+++ lib/lp/translations/javascript/importqueue.js	2012-05-16 16:32:21 +0000
@@ -180,10 +180,8 @@
         });
     Y.one('#import-queue-submit').addClass('hidden');
 };
-
-}, "0.1", {
-    // "oop" and "event" are required to fix known bugs in YUI, which
-    // are apparently fixed in a later version.
-    "requires": ["oop", "event", "node", "widget", "plugin", "overlay",
-                 "lazr.choiceedit", "lp.client", "lp.client.plugins",
-                 "lp.app.errors"]});
+// "oop" and "event" are required to fix known bugs in YUI, which
+// are apparently fixed in a later version.
+}, "0.1", { "requires": ["oop", "event", "node", "widget", "plugin",
+    "overlay", "lazr.choiceedit", "lp.client", "lp.client.plugins",
+    "lp.app.errors"]});