launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/static-privacy-portlet-text-1000667 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1000667 in Launchpad itself: "Initial information type text in bug privacy portlet is wrong"
  https://bugs.launchpad.net/launchpad/+bug/1000667

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/static-privacy-portlet-text-1000667/+merge/106129

== Implementation ==

Render the correct information type description in the TAL and do not rely on javascript to initially set it.

== Tests ==

Update some existing tests:
- TestBugView.test_information_type()
- TestBugView.test_userdata_shown_as_private()
- test_information_type_choice yui test

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/browser/bug.py
  lib/lp/bugs/browser/tests/test_bugview.py
  lib/lp/bugs/javascript/information_type_choice.js
  lib/lp/bugs/javascript/tests/test_information_type_choice.js
  lib/lp/bugs/templates/bug-portlet-privacy.pt

-- 
https://code.launchpad.net/~wallyworld/launchpad/static-privacy-portlet-text-1000667/+merge/106129
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/static-privacy-portlet-text-1000667 into lp:launchpad.