launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Curtis Hovey has proposed merging lp:~sinzui/launchpad/overlay-scrolling into lp:launchpad.

Requested reviews:
  Curtis Hovey (sinzui): ui
Related bugs:
  Bug #1001181 in Launchpad itself: "Bug, branch and merge proposal views have large amounts of horizontal overflow in Firefox"
  https://bugs.launchpad.net/launchpad/+bug/1001181

For more details, see:
https://code.launchpad.net/~sinzui/launchpad/overlay-scrolling/+merge/106457

Pre-implementation: no one

Bug, branch and merge proposal views are almost 100% wider than the
browser view (i.e. they have a huge horizontal scrollbar that scrolls
off into nothing) in Firefox (tested in Firefox Aurora [14] and Firefox
Nightly [15].)

Upon some initial inspection this seems to be related to the various
overlay elements (deleting these elements from the DOM reduces the
horizontal overflow.) This doesn't seem to be a problem in Chrome,
although I'm not exactly sure why.

.yui3-skin-sam button.lazr-btn has this insane rule
    text-indent: 100em;

This has been broken a long time, At least 30 days since I tested with a
tree that old. The bad CSS has existed for years. This bug was
introduced many months ago when style-sheets were re-arranged, or maybe
this is a problem seen only in the most recent firefoxes.

--------------------------------------------------------------------

RULES

    * Use a text-indent number that does not create a scrollbar in firefox.
      Given that any Lp page is between 60 and 70ems wide, the offset of
      100 exceeds the page width. The icon is about 1em wide, 2ems is all
      the ideal. 


QA

    Use Chromium and firefox
    * Visit https://code.qastaging.launchpad.net/~sinzui/gdp/packaging
    * Verify that the page does not have a horizontal scrollbar.


LINT

    lib/lp/app/javascript/lazr/assets/skins/sam/lazr-skin.css


TEST

    None.


IMPLEMENTATION

I used 3ems because browsers have small differences that may differ by .5em.
    lib/lp/app/javascript/lazr/assets/skins/sam/lazr-skin.css
-- 
https://code.launchpad.net/~sinzui/launchpad/overlay-scrolling/+merge/106457
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.