launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Needs Fixing code

The changes look good, but this branch is missing tests.
    lib/lp/app/browsers/tests/test_formatters.py
was not updated. The renaming of public_private_css => global_css should have broken the existing tests. I expect to see tests for the new rules.

I am surprised that the change of .beta-banner =>.global-notification in
    lib/lp/app/javascript/banners/beta-notification.js
did not break a js test because this is a contract between the js and css.

The two new properties in lib/lp/services/webapp/publisher.py need tests.
-- 
https://code.launchpad.net/~jcsackett/launchpad/progressively-enhanced-banners/+merge/106487
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.