← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~rvb/maas/morphing-tests into lp:maas

 

The proposal to merge lp:~rvb/maas/morphing-tests into lp:maas has been updated.

Description changed to:

I decided to finish up Huw's branch (see https://code.launchpad.net/~huwshimi/maas/morphing-tests/+merge/102056).  Huw won't have time to finish it in the foreseeable future.  I've fixed the conflicts and implemented the changes I suggested on the MP (!).

= Pre-imp =

Talked very briefly about this with jtv.  Neither he nor me want to have a lingering branch like this so I decided to take the bull by the horns and finish it up.

= Notes =

I've refactored all of the "animation creating" methods into module level methods.  This way, they are completely self-contained and easy to test.  Note that I've left the existing functionality (the morphing stuff) completely untouched in essence.

For more details, see:
https://code.launchpad.net/~rvb/maas/morphing-tests/+merge/106531
-- 
https://code.launchpad.net/~rvb/maas/morphing-tests/+merge/106531
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/morphing-tests into lp:maas.


References