← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~dooferlad/launchpad/postponed-is-done into lp:launchpad

 

Review: Approve code

This branch looks good.

Here's one tiny thing you might want to tweak: The original code
included superfluous calls to "float".  Since multiplication and
division have the same priority in order of operation and there is a
float (100.0) as the first operand, we don't need the calls to "float"
on lines 29 and 52 of the diff (in person.py).

Thanks for the improvement.
-- 
https://code.launchpad.net/~dooferlad/launchpad/postponed-is-done/+merge/106611
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References