← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~allenap/maas/try-out-saucelabs into lp:maas

 

> Thanks for doing this.  Not a full review (yet), but a note about the changes
> in test_js.py:
... 
> This is pretty hard to follow, and it indents into dizzying heights.

I've moved get_failed_tests_message to a new module, maastesting.yui3,
and decomposed it into smaller, easier to understand functions. And
tested them.

-- 
https://code.launchpad.net/~allenap/maas/try-out-saucelabs/+merge/106217
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/try-out-saucelabs into lp:maas.


References