launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

> More notes follow:
> 
> YUIUnitTestsRemote could also do with some documentation.  For
> example, what happens when I run tests without a connection to the
> SauceLabs site?

Erm, it'll break. It's not designed to run without a connection to
SauceLabs, and doesn't allow you to even try it. I'll see if there's
something else I can add there to make things clearer.

> 
> Copying dozens of port numbers into a comment there is error-prone.
> The list is likely to change.  (Are they stark raving mad to just
> grab all these ports?)

I've removed the quoted bit and just referred to the docs.

> 
> By the way, according to Clarkson this should get you shot:
> 
> 345     === added file 'src/maastesting/httpd.py'
> 346     --- src/maastesting/httpd.py    1970-01-01 00:00:00 +0000
> 347     +++ src/maastesting/httpd.py    2012-05-17 16:13:19 +0000
> 
> 373     +class ThreadingHTTPServer(ThreadingMixIn, HTTPServer):
> 374     +    """A simple HTTP Server that whill run in it's own thread."""

I don't understand, sorry :-/

-- 
https://code.launchpad.net/~allenap/maas/try-out-saucelabs/+merge/106217
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/try-out-saucelabs into lp:maas.