launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Review: Approve code

Looks good.

The with/pass in test_generate_extra_overrides.py (line 877 of the diff)
confused me for a second.  I wonder if an old-fashioned open().close()
wouldn't be easier to understand at first blush.  Or maybe even a
"touch" helper function.

-- 
https://code.launchpad.net/~cjwatson/launchpad/germinate-stale-files/+merge/106626
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.