launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/builder-description-mandatory into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #984342 in Launchpad itself: "description field for builder is optional but mandatory for DB"
  https://bugs.launchpad.net/launchpad/+bug/984342

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/builder-description-mandatory/+merge/106729

The schema for Builder states that the description is NOT NULL, but the IBuilder interface states the description is required=False. Fix the interface.
-- 
https://code.launchpad.net/~stevenk/launchpad/builder-description-mandatory/+merge/106729
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/builder-description-mandatory into lp:launchpad.

=== modified file 'lib/lp/buildmaster/interfaces/builder.py'
--- lib/lp/buildmaster/interfaces/builder.py	2012-02-09 23:09:36 +0000
+++ lib/lp/buildmaster/interfaces/builder.py	2012-05-22 01:14:20 +0000
@@ -140,7 +140,7 @@
             'The builder slave title. Should be just a few words.')))
 
     description = exported(Description(
-        title=_('Description'), required=False,
+        title=_('Description'), required=True,
         description=_('The builder slave description, may be several '
                       'paragraphs of text, giving the highlights and '
                       'details.')))