launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve code

Ok Ian, this was a little rough to get through, but I think I've got a couple of questions. Nothing killer and don't want to hold you up so approving, but please look into the following:


Line 346 removal, was that unused but left hanging?

With the tests I'd prefer to see one safe case, where the job was run with things that should not be effected so that we can make sure that it's safe to run with a control group.

#980 you no longer use the flat table for the query? Is this intentional?

#1127 you add the user to the deletePillarSharee, but I don't see that the arg is added to the actual method.
-- 
https://code.launchpad.net/~wallyworld/launchpad/bug-unsubscribe-pillar-infotype-change/+merge/106792
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.