launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

121	+ if (self.stacked_on and self.stacked_on.information_type in
122	+ PRIVATE_INFORMATION_TYPES and information_type in
123	+ PUBLIC_INFORMATION_TYPES):

This linebreaking is still a capital offence in several jurisdictions. One legal spelling is this:

if (self.stacked on
    and self.stacked_on.information_type in PRIVATE_INFORMATION TYPES
    and information_type in PUBLIC_INFORMATION TYPES):

157	+ # If the branch we are stacking on is not public, and we are,
158	+ # set our information_type to the stacked on's.

This comment should explain why.

159	+ if (self.stacked_on and self.stacked_on.information_type not in
160	+ PUBLIC_INFORMATION_TYPES and self.information_type in
161	+ PUBLIC_INFORMATION_TYPES):

Another capital offence.

273	+ branch = self.factory.makeBranch(
274	+ name='branch_%s' % x, private=x > 2)

That linebreak is probably no longer required.
-- 
https://code.launchpad.net/~stevenk/launchpad/branch-use-information_type/+merge/106109
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.