← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~danilo/launchpad/bug-1000787 into lp:launchpad

 

Review: Approve code*

The code looks good, tests pass, thank you.
Just a suggestion: maybe the code in lines 9..11 could be simplified, e.g.::

    container = containers_by_spec.setdefault(milestone, {}).get(spec)

-- 
https://code.launchpad.net/~danilo/launchpad/bug-1000787/+merge/107041
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References