launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Needs Fixing code

This JavaScript belongs in a module and requires a YUI test to verify it works. The lint report of the module will catch errors that commonly break older browsers as well as pointing out style issue. JavaScript uses 4-space identation

Avoid
    var things = new Array();
Use
   var things = [];


The floated div must be before the text "Blueprint" to display consistently across browsers. There is leading white-space.

I think this template is creating non-unique ids. This breaks many browsers. A proper test would catch this.
-- 
https://code.launchpad.net/~dooferlad/launchpad/upcomingwork-expand-all/+merge/107083
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.