← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjwatson/launchpad/remove-daily-installers into lp:launchpad

 

Review: Approve

Colin--

Great! I love seeing things simplified/deleted.

I'm a little concerned that distroseriesqueue-debian-installer was the only test around this and even that only checked via one line; I would ask for more checking for tests but as you're planning on following up with proper unit tests anyway we'll just trust ec2 to ferret out anything else that needs fixing.

Thanks!

-- 
https://code.launchpad.net/~cjwatson/launchpad/remove-daily-installers/+merge/107136
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


Follow ups

References