launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~bac/launchpad/cleanish into lp:launchpad

To: Brad Crittenden <bac@xxxxxxxxxxxxx>
From: Gary Poster <gary.poster@xxxxxxxxxxxxx>
Date: Fri, 25 May 2012 14:05:24 -0000
In-reply-to: <20120525135024.5237.80938.launchpad@ackee.canonical.com>
Reply-to: mp+107385@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Thank you!

Please file a bug for the longer term issue of bug 1004088: our tests should pass without an Apache configuration.  Then convert the comment in line 27ff to be an XXX, referencing the new bug and noting that, once that new bug is fixed, parallel testing ought to be able to switch to using make inplace rather than make install and then this make target can be collapsed once again into a single "clean" target.
-- 
https://code.launchpad.net/~bac/launchpad/cleanish/+merge/107385
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~bac/launchpad/cleanish into lp:launchpad
From: Brad Crittenden, 2012-05-25