launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/launchpad/bug-1003200 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1003200 in Launchpad itself: "lp.bugs.tests.test_bugchanges.TestBugChanges.test_change_information_type_using_api fails intermittently/rarely in parallel tests (again)"
  https://bugs.launchpad.net/launchpad/+bug/1003200

For more details, see:
https://code.launchpad.net/~bac/launchpad/bug-1003200/+merge/107681

= Summary =

Previous fix to the wadl generation caching problem was done
incorrectly.  Any existing wadl file needs to be copied so it can be
later restored. 

== Proposed fix ==

Use dict.copy()

== Tests ==

Create testlist with:
lp.services.webservice.tests.test_wadl_generation.SmokeTestWadlAndDocGeneration.test_wadl
lp.bugs.tests.test_bugchanges.TestBugChanges.test_change_information_type_using_api

bin/test --load-list testlist

== Demo and Q/A ==

N/A

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/webservice/tests/test_wadl_generation.py
-- 
https://code.launchpad.net/~bac/launchpad/bug-1003200/+merge/107681
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/bug-1003200 into lp:launchpad.

=== modified file 'lib/lp/services/webservice/tests/test_wadl_generation.py'
--- lib/lp/services/webservice/tests/test_wadl_generation.py	2012-05-11 15:39:38 +0000
+++ lib/lp/services/webservice/tests/test_wadl_generation.py	2012-05-28 19:04:23 +0000
@@ -24,7 +24,7 @@
     layer = LaunchpadFunctionalLayer
 
     def test_wadl(self):
-        preexisting_wadl_cache = WebServiceApplication.cached_wadl
+        preexisting_wadl_cache = WebServiceApplication.cached_wadl.copy()
         config = getUtility(IWebServiceConfiguration)
         for version in config.active_versions:
             wadl = generate_wadl(version)