launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/testfix-no-builder-description into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/testfix-no-builder-description/+merge/107913

Stop using IBuilderSet.new() to create builders. This better be the last vestiges of Builder.description, or I'm going to kick a puppy. A cute one.
-- 
https://code.launchpad.net/~stevenk/launchpad/testfix-no-builder-description/+merge/107913
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/testfix-no-builder-description into lp:launchpad.

=== modified file 'lib/lp/soyuz/tests/test_hasbuildrecords.py'
--- lib/lp/soyuz/tests/test_hasbuildrecords.py	2012-05-14 04:49:00 +0000
+++ lib/lp/soyuz/tests/test_hasbuildrecords.py	2012-05-30 05:41:19 +0000
@@ -16,7 +16,6 @@
     BuildFarmJobType,
     BuildStatus,
     )
-from lp.buildmaster.interfaces.builder import IBuilderSet
 from lp.buildmaster.interfaces.buildfarmjob import IBuildFarmJob
 from lp.buildmaster.interfaces.packagebuild import IPackageBuildSource
 from lp.registry.interfaces.person import IPersonSet
@@ -221,10 +220,9 @@
         owner = self.factory.makePerson()
         processor_family = ProcessorFamilySet().getByProcessorName('386')
         processor = processor_family.processors[0]
-        builder_set = getUtility(IBuilderSet)
-        self.context = builder_set.new(
+        self.context = self.factory.makeBuilder(
             processor, 'http://example.com', 'Newbob', 'New Bob the Builder',
-            'A new and improved bob.', owner)
+            owner=owner)
 
         # Ensure that our builds were all built by the test builder.
         for build in self.builds:
@@ -350,7 +348,7 @@
             publisher.prepareBreezyAutotest()
             publisher.addFakeChroots(distroseries=distroseries)
             distroseries.nominatedarchindep = das
-            builder = self.factory.makeBuilder(processor=pf_proc)
+            self.factory.makeBuilder(processor=pf_proc)
         spph = self.factory.makeSourcePackagePublishingHistory(
             sourcepackagename=spn, distroseries=distroseries)
         spph.createMissingBuilds()