← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/custom-upload-parsing into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Wed, 30 May 2012 05:54:17 -0000
In-reply-to: <20120528153617.25726.63758.launchpad@ackee.canonical.com>
Reply-to: mp+107656@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

Looks reasonable to me, although I'd personally prefer to turn getSeriesKey into a classmethod and merge setTargetDirectory back into __init__.
-- 
https://code.launchpad.net/~cjwatson/launchpad/custom-upload-parsing/+merge/107656
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/custom-upload-parsing into lp:launchpad
From: Colin Watson, 2012-05-28