← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~lifeless/launchpad/generate-htaccess-speed into lp:launchpad

To: mp+108074@xxxxxxxxxxxxxxxxxx
From: Jonathan Lange <jml@xxxxxxxxxxxxx>
Date: Wed, 30 May 2012 22:55:20 -0000
In-reply-to: <20120530225218.29147.59910.launchpad@ackee.canonical.com>
Reply-to: mp+108074@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Thanks for nailing this. Only suggestion is to add a comment before 'tokens = list(tokens)' explaining why you are doing this. 
-- 
https://code.launchpad.net/~lifeless/launchpad/generate-htaccess-speed/+merge/108074
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/generate-htaccess-speed into lp:launchpad.

References

[Merge] lp:~lifeless/launchpad/generate-htaccess-speed into lp:launchpad
From: Robert Collins, 2012-05-30