launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/anon-meta-lookup into lp:maas has been updated.

Description changed to:

As discussed with Daviey and Julian, in separate sessions.  This change supports two different use-cases for an alternative access path to nodes' metadata: debug access to any node's metadata in development environments, and testing with hardware that we have trouble passing boot parameters to (such as metadata credentials).  For the former we may want to add a more human-friendly lookup key later, such as a node's system_id, but this branch lays the groundwork.

A later branch will hook a new subtree into the metadata API that provides access to metadata keyed by MAC address.

Some detail about the code change: previously, a single function get_node_for_request looked up which node a given metadata request was for and from, or raised an error if the access was not allowed.  I split that up into two levels: get_queried_node finds the node that metadata is being queried for, but delegates both authorization and lookup to either get_node_for_request (the pre-existing function) or get_node_for_mac (if anonymous access is requested for an explicit MAC address).

A new setting controls the ability to do this.  Sprinkled liberally, of course, with Kids, Don't Try This At Home™.


Jeroen

For more details, see:
https://code.launchpad.net/~jtv/maas/anon-meta-lookup/+merge/108292
-- 
https://code.launchpad.net/~jtv/maas/anon-meta-lookup/+merge/108292
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/anon-meta-lookup into lp:maas.