launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/denorm-spph-source_package_name into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #848563 in Launchpad itself: "SPPH.source_package_name and BPPH.binary_package_name can be deprecated"
  https://bugs.launchpad.net/launchpad/+bug/848563

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/denorm-spph-source_package_name/+merge/108520

SPPH.sourcepackagename and BPPH.binarypackagename have been fully populated for a while and NOT NULL. We should use them in more places. We can't dump source_package_name entirely, but we can stop it joining via SPR. (And the same for binary_package_name)
-- 
https://code.launchpad.net/~stevenk/launchpad/denorm-spph-source_package_name/+merge/108520
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/denorm-spph-source_package_name into lp:launchpad.

=== modified file 'lib/lp/soyuz/model/publishing.py'
--- lib/lp/soyuz/model/publishing.py	2012-05-21 07:34:15 +0000
+++ lib/lp/soyuz/model/publishing.py	2012-06-04 05:04:22 +0000
@@ -709,12 +709,10 @@
         return self.distroseries.distribution.getSourcePackageRelease(
             self.supersededby)
 
-    # XXX: StevenK 2011-09-13 bug=848563: This can die when
-    # self.sourcepackagename is populated.
     @property
     def source_package_name(self):
         """See `ISourcePackagePublishingHistory`"""
-        return self.sourcepackagerelease.name
+        return self.sourcepackagename.name
 
     @property
     def source_package_version(self):
@@ -980,12 +978,10 @@
         """See `IBinaryPackagePublishingHistory`"""
         return self.distroarchseries.distroseries
 
-    # XXX: StevenK 2011-09-13 bug=848563: This can die when
-    # self.binarypackagename is populated.
     @property
     def binary_package_name(self):
         """See `IBinaryPackagePublishingHistory`"""
-        return self.binarypackagerelease.name
+        return self.binarypackagename.name
 
     @property
     def binary_package_version(self):